Fix: Erroneous calculation of content-length can lead to errors on … #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…client-side due to chopping of JSON reponse in certain situations (problem related to character encoding)
Member
|
Thanks for the fix! |
|
Another symptom of the issue that some of the requests are hanging infinitely. I'm using Dropwizard as a server and I think Dropwizard tries to wait for the "full" content which never happens. Thanks for finding it and fixing, @apae89! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…client-side due to chopping of JSON reponse in certain situations (problem related to character encoding). Length must contain the number of bytes calculated using the expected response encoding, instead of the number of characters.
Problem already leads to errors when using some special Unicode characters within response content.